jakub
6a667d8deb
Include the current addon, terrain integrations, tools, regression tests and recorded development evidence.
57 lines
4.6 KiB
JSON
57 lines
4.6 KiB
JSON
{
|
|
"verdict": "No concrete blocker found in final paired service addition. Read-only source/test review; no independent compiler/native execution in this review.",
|
|
"source_manifest": {
|
|
"addons/core/Scripts/Game/ERR/10_AI/ERR_ConvoyService.c": "b59016d83cb9d40136b98b4e0067ea490bc553574fc53603593efd5522dbed20",
|
|
"tests/test_convoy_intercept_pair.py": "52b55727b7c2441d43530efa701045b9439b9175c71fbd2ae7577f851d2c98ec",
|
|
"fix.patch": "dd034f9837703ba3cbf157490999152ef1d00fae7878c5fe8073d808e3abe1c4"
|
|
},
|
|
"source_manifest_sha256": "e27b7654dd458683e8689f1621149b589070ea0177588c08c7328d7d2604cf86",
|
|
"baseline_still_matches_target": true,
|
|
"addition_only_existing_singleton_and_release_paths_unchanged": true,
|
|
"reviewed_invariants": [
|
|
"Reserve pair requires distinct original groups/vehicle slots/tokens/entities in exact admitted task and consumed receipt; real ledger records and original crew ownership pass existing InterceptEligible for each. Same delivered belief/report/revision/times and >=40m spacing; global existing interception prevents other-task adoption.",
|
|
"First claim failure leaves both untouched; second claim failure clears only first exact owned claim and preserves original route handles/deadline. Tokens remain spent rather than replayable.",
|
|
"First or second waypoint allocation failure precedes any ClearOrder. Second failure deletes only first prepared waypoint. No physical actor, inventory, stock, pool receipt or ledger registration changes in added methods.",
|
|
"Both allocations followed by exact receipt/record/route/entity/crew/claim/destination revalidation before route mutation. Invalid precommit ownership deletes prepared handles only.",
|
|
"ClearOrder/AddWaypoint are native commit boundaries, not atomic transactions. Callback ownership loss prevents later partner installation and releases exact owned claims. No assertion that original native orders can be transactionally restored after removal.",
|
|
"Public replacement waypoint handles are not adopted/deleted by exact private cleanup; original actors/drivers retained. Shared fixed expiry and existing per-member route progression/resume retained."
|
|
],
|
|
"test_evidence_inspected": {
|
|
"path": "/tmp/erri-pair-service-0054/tests/test_convoy_intercept_pair.py",
|
|
"binding": "Reuses existing full actual vehicle/service C++ translation through ERR_CONVOY_SERVICE, then inserts actual pair methods. Native allocation/removal/addition are callback doubles.",
|
|
"cases": [
|
|
"19 malformed/foreign/invalid pair refusals",
|
|
"first and second allocation failure retain both original handle and Add/Remove counters",
|
|
"crew loss during allocation leaves routes intact and deletes both prepared handles",
|
|
"second claim rollback and unrelated global claim preservation",
|
|
"mutated claimed destinations refused",
|
|
"ClearOrder/first Add/second Add cancellation",
|
|
"both physical-position hold/expiry and exact per-member foreign-public-handle preservation"
|
|
],
|
|
"author_logs": {
|
|
"apply-check.log": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
|
|
"mutation-spacing-red.log": "d11417b94e4ddf6357314e03e6e8560e145e685d094dfaf5a4681171c02c39c7",
|
|
"mutation-rollback-red.log": "810fb2ce2337fe3f25ee3404b12a49a263e0310318e54cc2e7b3fe21119e9df7",
|
|
"baseline-red.log": "3282ef3cdcb9b5f5557227a37a795e310240d6d598dce23e261bc7fbe8dd308b",
|
|
"rules.log": "20410d8a7171f3e140f415186697a442452d6eeea8564d622ed093d2259bbc8d",
|
|
"lifecycle.log": "6e7f1708a5e9c0af68ffd0ace1edc33e99edff479cee2e6750bcaca1c94317ff",
|
|
"green.log": "376c9f1c0e0fa25eee0d283e57561cd2ed6d1b826a8c2fb9486d681e82ef0f8b"
|
|
},
|
|
"executed_by_reviewer": false
|
|
},
|
|
"hq_previous_finding": "Author corrected greedy roleA crew selection by bounded enumeration of each original escort as first choice. Independently inspected current loop; new test was reported green by author, not rerun here.",
|
|
"retained_limitations": [
|
|
"Legacy ClearIntercept calls native RemoveWaypoint before clearing token. No concrete direct recursive native callback demonstrated in this feature slice; behavior unchanged and not claimed newly qualified.",
|
|
"Native waypoint Add/Remove cannot guarantee transactional movement of two separate groups.",
|
|
"No actual native driving, paired hold/traffic blockage, radio timing, multiplayer or FPS evidence from source-level doubles."
|
|
],
|
|
"actions": {
|
|
"target_writes": false,
|
|
"original_writes": false,
|
|
"source_edits": false,
|
|
"tests_compilers": false,
|
|
"native": false
|
|
},
|
|
"reviewed_dispatch_sha256": "60d0fef83f43eea0501bf5fe46f369556e22acda6d034908b5965d8820b28893"
|
|
}
|