jakub
6a667d8deb
Include the current addon, terrain integrations, tools, regression tests and recorded development evidence.
55 lines
3.6 KiB
JSON
55 lines
3.6 KiB
JSON
{
|
|
"verdict": "Approved reviewed source and actual-method regression; no concrete blocker.",
|
|
"source_sha256": {
|
|
"ERR_HQ.c": "8efc1b478ba7e0826c412bddeecd852097d55df269fd8c952e65a345a55865c1",
|
|
"ERR_ConvoyService.c": "825a35f7afe485c1e5ddfc96dfff3498b39cce54dc19dce857b5d30fe5dc6557",
|
|
"ERR_SupplyConvoyTactics.c": "dc3acdffc8ca48f11b131f66d30d679ca68f3b3004344bdc78723bc9305915e0",
|
|
"tests/test_convoy_survivors.py": "db86f64be584d687afef8df8729dcd9c92dc13919d061699b2bb338782890f8b",
|
|
"tests/test_convoy_lifecycle.py": "fc18679882f1666a38587d151aa368241c5af115f3a8269dca81eb2617eb8afc",
|
|
"independent-green.log": "415fa2dfc0f1d7adcdaa1fd120af686b9771afc506487e9d4b1d1caaabc000cf",
|
|
"independent-baseline.log": "f766935d0f68a1e3e50afc39ea1fef54c865366440e15087d992294eff045dab",
|
|
"independent-lifecycle.log": "6e7f1708a5e9c0af68ffd0ace1edc33e99edff479cee2e6750bcaca1c94317ff"
|
|
},
|
|
"findings": [
|
|
"Release retains only same existing HQ unit with CONVOY record/source and bound original status roster. Requires current active mode/command and non-stopping HQ.",
|
|
"Living originals must still be present and attributable; duplicate, foreign/replacement agents and player ownership rejected. Vehicle path separately rejects Captured; team path requires no player-controlled group via HQ helper.",
|
|
"No RegisterGroup, new roster, equipment grant or resource creation. Retaining same sampler preserves permanent released slots.",
|
|
"Only pending convoy downlink is cancelled. ReleaseRecovery clears travel support role; LogisticsReservation is unchanged so accepted inventory uncertainty remains excluded until its existing owner settles.",
|
|
"Normal Release still clears original route/intercept/crew holds and unpins record; failed retention/terminal/capture still unregisters.",
|
|
"HQUnit.Eligible remains false while any conscious member seated; no forced dismount or automatic pathfinding outcome claimed."
|
|
],
|
|
"native_evidence": {
|
|
"file": "/home/jakub/devel/escapistsrereintroduced/docs/evidence/native-2026-10-02-convoy-loss-diagnostic/console.log.txt",
|
|
"sha256": "de6bd49e3e89ee6cd582a54accd9ae04a12fc3c6e9c2f12b43d356de1b54f461",
|
|
"lines": "774-787",
|
|
"observation": "Released troop Ural slot2, vehicle alive, enemy group, nine originals alive/nonplayer/sameGroup; driver CanFight but aboard0; routeIndex0/19, now24603.3<deadline618363; taskReady1/taskStopped0.",
|
|
"limitation": "Failure-time current state only. Does not establish earlier exact release trigger."
|
|
},
|
|
"tests_run": true,
|
|
"native_runs_by_reviewer": false,
|
|
"target_writes": false,
|
|
"independent_tests": [
|
|
{
|
|
"name": "test_convoy_survivors.py proposal",
|
|
"result": "PASS",
|
|
"log": "independent-green.log"
|
|
},
|
|
{
|
|
"name": "test_convoy_survivors.py baseline",
|
|
"result": "Compiled then SIGABRT at original HQ retention assertion; expected regression red",
|
|
"log": "independent-baseline.log"
|
|
},
|
|
{
|
|
"name": "test_convoy_lifecycle.py proposed service",
|
|
"result": "PASS",
|
|
"log": "independent-lifecycle.log"
|
|
}
|
|
],
|
|
"limits": [
|
|
"Sampler/native boundary doubled in regression; actual Release, HQ retention, eligibility, ReleaseRecovery and ReleaseLogistics methods execute. No native post-fix survivor/report outcome claimed.",
|
|
"Exact-token test proves cleanup API retains wrong-token claim then releases matching token; complete delayed inventory callback state machine not rerun in this bounded review."
|
|
],
|
|
"patch_sha256": "0854cbc00212ebb0605253446ebac1894a3501330ca50fb97706ade5c2796703",
|
|
"frozen_review_inputs_unchanged": true
|
|
}
|