Update mikrotikbackup_clean.yml

mikrotikbackup_clean.yml

@@ -1,108 +1,251 @@
+---
 - name: Backup and/or Upgrade MikroTik
   hosts: mikrotik_routers
   gather_facts: no
+  serial: 10
  
   vars:
     backup_dir: /opt/mikrotik_backups/
+    checkmk_url: "http://192.168.19.8:8080/cmk/check_mk/api/1.0/domain-types/host_service_passive_check/actions/set/invoke"
+    checkmk_user: "apitoken"
+    checkmk_token: "YXBpdG9rZW46TkVXX1NFQ1JFVA=="
+    checkmk_service_description: "MikroTik Backup/Upgrade"
  
   tasks:
  
     # ----------------------------
-    # Always: identity + timestamp
+    # Identity + timestamp
     # ----------------------------
     - name: Get router identity
       community.routeros.command:
         commands: /system identity print
       register: identity_raw
-      tags: always
  
     - name: Parse router name
       set_fact:
         router_name: "{{ identity_raw.stdout[0].split(': ')[1] | trim }}"
-      tags: always
  
     - name: Get timestamp
-      ansible.builtin.command: date +%Y-%m-%d_%H-%M-%S
+      command: date +%Y-%m-%d_%H-%M-%S
       register: date_out
       delegate_to: localhost
-      tags: always
+      changed_when: false
  
-    - name: Set timestamp fact
+    - name: Set timestamp
       set_fact:
         ts: "{{ date_out.stdout }}"
-      tags: always
  
     # ----------------------------
-    # Backup (tag: backup)
+    # Backup
     # ----------------------------
-    - name: Ensure local backup directory exists
-      ansible.builtin.file:
+    - name: Ensure backup directory exists
+      file:
         path: "{{ backup_dir }}"
         state: directory
         mode: "0755"
       delegate_to: localhost
-      tags: [backup, never]
  
     - name: Export router config
       community.routeros.command:
         commands: /export terse show-sensitive
       register: export_cfg
-      tags: [backup, never]
  
     - name: Save export locally
-      ansible.builtin.copy:
+      copy:
         content: "{{ export_cfg.stdout[0] }}"
         dest: "{{ backup_dir }}/{{ router_name }}-{{ ts }}.rsc"
+        mode: "0600"
       delegate_to: localhost
-      tags: [backup, never]
  
-    # ----------------------------
-    # Upgrade (tag: upgrade)
-    # ----------------------------
-    - name: Check current and latest available package versions
-      community.routeros.command:
-        commands: /system package update check-for-updates
-      register: update_check
-      tags: [upgrade, never]
-
-    - name: Parse installed and latest versions
+    - name: Mark backup success
       set_fact:
-        installed_version: "{{ update_check.stdout[0] | regex_search('installed-version: ([\\d.]+)', '\\1') | first }}"
-        latest_version: "{{ update_check.stdout[0] | regex_search('latest-version: ([\\d.]+)', '\\1') | first }}"
-      tags: [upgrade, never]
+        backup_file: "{{ backup_dir }}/{{ router_name }}-{{ ts }}.rsc"
  
-    - name: Skip upgrade if already on latest
-      ansible.builtin.debug:
-        msg: "Router {{ router_name }} is already on latest version {{ installed_version }}. Skipping upgrade."
-      when: installed_version == latest_version
-      tags: [upgrade, never]
+    # ----------------------------
+    # Update check
+    # ----------------------------
+    - name: Trigger update check
+      community.routeros.command:
+        commands: /system package update check-for-updates once
  
-    - name: Trigger package download and install
+    - name: Wait for MikroTik
+      pause:
+        seconds: 5
+ 
+    - name: Get update info
+      community.routeros.command:
+        commands: /system package update print
+      register: update_info
+ 
+    # ----------------------------
+    # Parsing
+    # ----------------------------
+    - name: Extract installed version
+      set_fact:
+        installed_version: >-
+          {{
+            update_info.stdout[0]
+            | regex_search('installed-version:\s*(\S+)', '\1')
+            | first
+            | default('unknown')
+            | trim
+          }}
+ 
+    - name: Extract latest version
+      set_fact:
+        latest_version: >-
+          {{
+            update_info.stdout[0]
+            | regex_search('latest-version:\s*(\S+)', '\1')
+            | first
+            | default('unknown')
+            | trim
+          }}
+ 
+    - name: Extract status
+      set_fact:
+        update_status: >-
+          {{
+            update_info.stdout[0]
+            | regex_search('status:\s*(.+)', '\1')
+            | first
+            | default('unknown')
+            | trim
+          }}
+ 
+    - name: Extract channel
+      set_fact:
+        update_channel: >-
+          {{
+            update_info.stdout[0]
+            | regex_search('channel:\s*(\S+)', '\1')
+            | first
+            | default('unknown')
+            | trim
+          }}
+ 
+    - name: Debug parsed values
+      debug:
+        msg: >
+          router={{ router_name }}
+          channel={{ update_channel }}
+          installed={{ installed_version }}
+          latest={{ latest_version }}
+          status={{ update_status }}
+ 
+    # ----------------------------
+    # Logic
+    # ----------------------------
+    - name: Detect update failure
+      set_fact:
+        update_failed: "{{ 'error' in (update_status | lower) or 'failed' in (update_status | lower) }}"
+ 
+    - name: Decide upgrade
+      set_fact:
+        upgrade_needed: >-
+          {{
+            not update_failed | bool and
+            installed_version != 'unknown' and
+            latest_version != 'unknown' and
+            installed_version != latest_version
+          }}
+ 
+    - name: Show decision
+      debug:
+        msg: "Router={{ router_name }} installed={{ installed_version }} latest={{ latest_version }} upgrade_needed={{ upgrade_needed }}"
+ 
+    - name: Skip upgrade (already up to date)
+      debug:
+        msg: "Router {{ router_name }} is already up to date ({{ installed_version }})"
+      when: not upgrade_needed | bool
+ 
+    # ----------------------------
+    # Upgrade
+    # ----------------------------
+    - name: Install update
       community.routeros.command:
         commands: /system package update install
+      when: upgrade_needed | bool
       register: upgrade_result
-      when: installed_version != latest_version
-      tags: [upgrade, never]
  
-    - name: Wait for router to come back online after reboot
-      ansible.builtin.wait_for_connection:
+    - name: Wait for reboot
+      wait_for_connection:
         delay: 180
-        timeout: 300
+        timeout: 600
         sleep: 10
       when:
-        - installed_version != latest_version
-        - upgrade_result is not failed
-      tags: [upgrade, never]
+        - upgrade_needed | bool
+        - upgrade_result is succeeded
  
-    - name: Confirm upgraded version
+    - name: Confirm version after upgrade
       community.routeros.command:
         commands: /system resource print
       register: post_upgrade_info
-      when: installed_version != latest_version
-      tags: [upgrade, never]
+      when: upgrade_needed | bool
+ 
+    - name: Parse new version
+      set_fact:
+        post_upgrade_version: >-
+          {{
+            post_upgrade_info.stdout[0]
+            | regex_search('version:\s*(\S+)', '\1')
+            | first
+            | default('unknown')
+            | trim
+          }}
+      when: upgrade_needed | bool
+ 
+    # ----------------------------
+    # Checkmk
+    # ----------------------------
+    - name: Result when no upgrade needed
+      set_fact:
+        cmk_state: "{{ 2 if update_failed | bool else 0 }}"
+        cmk_output: >-
+          {{ 'CRIT' if update_failed | bool else 'OK' }} -
+          router={{ router_name }}
+          installed={{ installed_version }}
+          latest={{ latest_version }}
+          status="{{ update_status }}"
+          upgrade_needed=no
+      when: not upgrade_needed | bool
+ 
+    - name: Result when upgrade happened
+      set_fact:
+        cmk_state: "{{ 0 if post_upgrade_version == latest_version else 2 }}"
+        cmk_output: >-
+          {{ 'OK' if post_upgrade_version == latest_version else 'CRIT' }} -
+          router={{ router_name }}
+          upgraded_from={{ installed_version }}
+          upgraded_to={{ post_upgrade_version }}
+          latest={{ latest_version }}
+      when: upgrade_needed | bool
+ 
+    - name: Send result to Checkmk
+      delegate_to: localhost
+      uri:
+        url: "{{ checkmk_url }}"
+        method: POST
+        url_username: "{{ checkmk_user }}"
+        url_password: "{{ checkmk_token }}"
+        force_basic_auth: yes
+        headers:
+          Content-Type: "application/json"
+          Accept: "application/json"
+        body_format: json
+        body:
+          host_name: "mikrotiks"
+          service_description: "{{ checkmk_service_description }}"
+          state: "{{ cmk_state | int }}"
+          output: "{{ cmk_output }}"
+      failed_when: false
+      register: cmk_result
+ 
+    - name: Debug Checkmk response
+      debug:
+        msg: "status={{ cmk_result.status }} body={{ cmk_result.json | default(cmk_result.msg) }}"
+ 
+    - name: Show Checkmk output
+      debug:
+        var: cmk_output
  
-    - name: Show post-upgrade RouterOS version
-      ansible.builtin.debug:
-        msg: "{{ post_upgrade_info.stdout[0] | regex_search('version: .+') }}"
-      when: installed_version != latest_version
-      tags: [upgrade, never]