Update mikrotikbackup_clean.yml

mikrotikbackup_clean.yml

@@ -1,251 +1,108 @@
----
 - name: Backup and/or Upgrade MikroTik
   hosts: mikrotik_routers
   gather_facts: no
-  serial: 10
+
- 
   vars:
     backup_dir: /opt/mikrotik_backups/
-    checkmk_url: "http://192.168.19.8:8080/cmk/check_mk/api/1.0/domain-types/host_service_passive_check/actions/set/invoke"
+
-    checkmk_user: "apitoken"
-    checkmk_token: "YXBpdG9rZW46TkVXX1NFQ1JFVA=="
-    checkmk_service_description: "MikroTik Backup/Upgrade"
- 
   tasks:
- 
+
     # ----------------------------
-    # Identity + timestamp
+    # Always: identity + timestamp
     # ----------------------------
     - name: Get router identity
       community.routeros.command:
         commands: /system identity print
       register: identity_raw
- 
+      tags: always
+
     - name: Parse router name
       set_fact:
         router_name: "{{ identity_raw.stdout[0].split(': ')[1] | trim }}"
- 
+      tags: always
+
     - name: Get timestamp
-      command: date +%Y-%m-%d_%H-%M-%S
+      ansible.builtin.command: date +%Y-%m-%d_%H-%M-%S
       register: date_out
       delegate_to: localhost
-      changed_when: false
+      tags: always
- 
+
-    - name: Set timestamp
+    - name: Set timestamp fact
       set_fact:
         ts: "{{ date_out.stdout }}"
- 
+      tags: always
+
     # ----------------------------
-    # Backup
+    # Backup (tag: backup)
     # ----------------------------
-    - name: Ensure backup directory exists
+    - name: Ensure local backup directory exists
-      file:
+      ansible.builtin.file:
         path: "{{ backup_dir }}"
         state: directory
         mode: "0755"
       delegate_to: localhost
- 
+      tags: [backup, never]
+
     - name: Export router config
       community.routeros.command:
         commands: /export terse show-sensitive
       register: export_cfg
- 
+      tags: [backup, never]
+
     - name: Save export locally
-      copy:
+      ansible.builtin.copy:
         content: "{{ export_cfg.stdout[0] }}"
         dest: "{{ backup_dir }}/{{ router_name }}-{{ ts }}.rsc"
-        mode: "0600"
       delegate_to: localhost
- 
+      tags: [backup, never]
-    - name: Mark backup success
+
-      set_fact:
-        backup_file: "{{ backup_dir }}/{{ router_name }}-{{ ts }}.rsc"
- 
     # ----------------------------
-    # Update check
+    # Upgrade (tag: upgrade)
     # ----------------------------
-    - name: Trigger update check
+    - name: Check current and latest available package versions
       community.routeros.command:
-        commands: /system package update check-for-updates once
+        commands: /system package update check-for-updates
- 
+      register: update_check
-    - name: Wait for MikroTik
+      tags: [upgrade, never]
-      pause:
+
-        seconds: 5
+    - name: Parse installed and latest versions
- 
-    - name: Get update info
-      community.routeros.command:
-        commands: /system package update print
-      register: update_info
- 
-    # ----------------------------
-    # Parsing
-    # ----------------------------
-    - name: Extract installed version
       set_fact:
-        installed_version: >-
+        installed_version: "{{ update_check.stdout[0] | regex_search('installed-version: ([\\d.]+)', '\\1') | first }}"
-          {{
+        latest_version: "{{ update_check.stdout[0] | regex_search('latest-version: ([\\d.]+)', '\\1') | first }}"
-            update_info.stdout[0]
+      tags: [upgrade, never]
-            | regex_search('installed-version:\s*(\S+)', '\1')
+
-            | first
+    - name: Skip upgrade if already on latest
-            | default('unknown')
+      ansible.builtin.debug:
-            | trim
+        msg: "Router {{ router_name }} is already on latest version {{ installed_version }}. Skipping upgrade."
-          }}
+      when: installed_version == latest_version
- 
+      tags: [upgrade, never]
-    - name: Extract latest version
+
-      set_fact:
+    - name: Trigger package download and install
-        latest_version: >-
-          {{
-            update_info.stdout[0]
-            | regex_search('latest-version:\s*(\S+)', '\1')
-            | first
-            | default('unknown')
-            | trim
-          }}
- 
-    - name: Extract status
-      set_fact:
-        update_status: >-
-          {{
-            update_info.stdout[0]
-            | regex_search('status:\s*(.+)', '\1')
-            | first
-            | default('unknown')
-            | trim
-          }}
- 
-    - name: Extract channel
-      set_fact:
-        update_channel: >-
-          {{
-            update_info.stdout[0]
-            | regex_search('channel:\s*(\S+)', '\1')
-            | first
-            | default('unknown')
-            | trim
-          }}
- 
-    - name: Debug parsed values
-      debug:
-        msg: >
-          router={{ router_name }}
-          channel={{ update_channel }}
-          installed={{ installed_version }}
-          latest={{ latest_version }}
-          status={{ update_status }}
- 
-    # ----------------------------
-    # Logic
-    # ----------------------------
-    - name: Detect update failure
-      set_fact:
-        update_failed: "{{ 'error' in (update_status | lower) or 'failed' in (update_status | lower) }}"
- 
-    - name: Decide upgrade
-      set_fact:
-        upgrade_needed: >-
-          {{
-            not update_failed | bool and
-            installed_version != 'unknown' and
-            latest_version != 'unknown' and
-            installed_version != latest_version
-          }}
- 
-    - name: Show decision
-      debug:
-        msg: "Router={{ router_name }} installed={{ installed_version }} latest={{ latest_version }} upgrade_needed={{ upgrade_needed }}"
- 
-    - name: Skip upgrade (already up to date)
-      debug:
-        msg: "Router {{ router_name }} is already up to date ({{ installed_version }})"
-      when: not upgrade_needed | bool
- 
-    # ----------------------------
-    # Upgrade
-    # ----------------------------
-    - name: Install update
       community.routeros.command:
         commands: /system package update install
-      when: upgrade_needed | bool
       register: upgrade_result
- 
+      when: installed_version != latest_version
-    - name: Wait for reboot
+      tags: [upgrade, never]
-      wait_for_connection:
+
+    - name: Wait for router to come back online after reboot
+      ansible.builtin.wait_for_connection:
         delay: 180
-        timeout: 600
+        timeout: 300
         sleep: 10
       when:
-        - upgrade_needed | bool
+        - installed_version != latest_version
-        - upgrade_result is succeeded
+        - upgrade_result is not failed
- 
+      tags: [upgrade, never]
-    - name: Confirm version after upgrade
+
+    - name: Confirm upgraded version
       community.routeros.command:
         commands: /system resource print
       register: post_upgrade_info
-      when: upgrade_needed | bool
+      when: installed_version != latest_version
- 
+      tags: [upgrade, never]
-    - name: Parse new version
+
-      set_fact:
+    - name: Show post-upgrade RouterOS version
-        post_upgrade_version: >-
+      ansible.builtin.debug:
-          {{
+        msg: "{{ post_upgrade_info.stdout[0] | regex_search('version: .+') }}"
-            post_upgrade_info.stdout[0]
+      when: installed_version != latest_version
-            | regex_search('version:\s*(\S+)', '\1')
+      tags: [upgrade, never]
-            | first
-            | default('unknown')
-            | trim
-          }}
-      when: upgrade_needed | bool
- 
-    # ----------------------------
-    # Checkmk
-    # ----------------------------
-    - name: Result when no upgrade needed
-      set_fact:
-        cmk_state: "{{ 2 if update_failed | bool else 0 }}"
-        cmk_output: >-
-          {{ 'CRIT' if update_failed | bool else 'OK' }} -
-          router={{ router_name }}
-          installed={{ installed_version }}
-          latest={{ latest_version }}
-          status="{{ update_status }}"
-          upgrade_needed=no
-      when: not upgrade_needed | bool
- 
-    - name: Result when upgrade happened
-      set_fact:
-        cmk_state: "{{ 0 if post_upgrade_version == latest_version else 2 }}"
-        cmk_output: >-
-          {{ 'OK' if post_upgrade_version == latest_version else 'CRIT' }} -
-          router={{ router_name }}
-          upgraded_from={{ installed_version }}
-          upgraded_to={{ post_upgrade_version }}
-          latest={{ latest_version }}
-      when: upgrade_needed | bool
- 
-    - name: Send result to Checkmk
-      delegate_to: localhost
-      uri:
-        url: "{{ checkmk_url }}"
-        method: POST
-        url_username: "{{ checkmk_user }}"
-        url_password: "{{ checkmk_token }}"
-        force_basic_auth: yes
-        headers:
-          Content-Type: "application/json"
-          Accept: "application/json"
-        body_format: json
-        body:
-          host_name: "mikrotiks"
-          service_description: "{{ checkmk_service_description }}"
-          state: "{{ cmk_state | int }}"
-          output: "{{ cmk_output }}"
-      failed_when: false
-      register: cmk_result
- 
-    - name: Debug Checkmk response
-      debug:
-        msg: "status={{ cmk_result.status }} body={{ cmk_result.json | default(cmk_result.msg) }}"
- 
-    - name: Show Checkmk output
-      debug:
-        var: cmk_output
-