Files
EscapistsReintroduced/docs/evidence/hq-recovery-reserve-2026-11-05/independent-review.json
T
jakub 9caed3f12d
continuous-integration/drone/push Build is passing
Embed RHS 1.9 compatibility; record Workshop 0.0.141
2026-11-05 16:39:35 +01:00

51 lines
4.0 KiB
JSON

{
"approved": true,
"files": {
"addons/core/Scripts/Game/ERR/10_AI/ERR_HQ.c": {
"before_sha256": "2334a96e1e29c70a9f3076f9fbef53949e39d5560e23d078639d73559cb0b823",
"after_sha256": "9bd25f9fc7e574c515c7131e8b52eb357e295822e1ce2f401e6e86cfd6ce062f"
},
"tests/test_hq_ammo_dispatch.py": {
"before_sha256": "e2e4dfb26e17b85953c2ba40a3732b04514ae3b8cf099e3ca67466c0a7b9a05b",
"after_sha256": "89858dcb20dc8da6856140223bbff38bf0cef2b62f081ed70b9d239c53197abb"
},
"tests/test_hq_delivered_task.py": {
"before_sha256": "2c535df5ea11969051e92d7fbeb2ff26e03f7eb20bfe69ead0067fd2d42bd7ec",
"after_sha256": "9fd05d454b07f15a90d01761684f7019c650d63587d9fe54e5cc131ee236b445"
}
},
"proposal_manifest_sha256": "3913aa39a8f0490dc95cd8b81862fcac124a05adbf575fb5010c87eabd45ac3a",
"patch_sha256": "55c7b38be296d287d5af3aa05749dd0ddc19507a041062e40109887839d6496e",
"reviewed_head": "9418b6950a12610361d96a99d058e9e10de03713",
"scope": "Independent read-only three-file source/test diff and retained evidence review. Reviewer did not compile, run tests or launch native. Live targets match recorded baselines; no whole-repository/index invariance claim. Concurrent garage/changelog changes are excluded.",
"findings": [
"Production change only widens known-empty admission for enabled coordinated positive-operation RESERVE when current original squad judgment exists and Recovering is true.",
"Existing WITHDRAW exemption and release-only path retained; ordinary tactical reserve and SEARCH/OBSERVE/FIX/FLANK/BLOCK remain rejected when known empty.",
"All later belief actionability, revision, expiry, eligible-unit, exact coordinated slot/task/execution and support/logistics/home-guard vetoes are unchanged.",
"Judgment lookup is existing public API on initialized m_Operations; pending order/task/downlink exclusion prevents planner roster resampling while that delivery is queued. No native API or resource dependency added.",
"Ammunition sampling/freshness and finite supply stock are unchanged. The exemption allows a recovery hold; it does not produce rounds or establish replenishment.",
"Existing harness assertions remain; extension replaces a blanket coordinated-refusal double with actual CoordinatedDelivery and adds reserve positive/negative controls."
],
"tested_scope": {
"author_logs_sha256": {
"green-delivery.log": "3e4c1177f828b2b47baa6fb274ed2ac27ca33fee42e75f49dfbd0124cd5049dd",
"green-ammo.log": "8aa65db678e64c600682c049ced50cf12fdaed343c64c228d7bf182d6bf8cb3b",
"baseline-red.log": "09fd626e64135553a80e909d0791d13ecaec01af69297fb1e4e7189afac071f6",
"mutation-red.log": "467da3d81928a1f2081ac04160dfc24e3d387b80a8ff090a4a6277ff4c1b884c"
},
"baseline": "Exact final full-delivery test compiled, then failed first empty-ammo recovery RESERVE assertion with SIGABRT.",
"proposal": "Author green logs cover actual full DeliverOrder and actual CoordinatedDelivery, positive recovering reserve, unchanged WITHDRAW without judgment, ordinary armed reserve, 15 rejection controls and five attacking roles, plus existing ammo admission/release tests.",
"mutation": "Retained attempted broad-reserve mutation is compile failure (unused squad under -Werror), not behavioral/runtime evidence; excluded from correctness claim."
},
"limits": [
"Opaque native waypoint/group, memory/watch and judgment lookup boundaries are doubled.",
"No native compilation, radio transit, physical withdrawal/arrival/resupply, multiplayer or performance result is established by this proposal.",
"Existing planner tests/source establish withdrawal-to-reserve policy separately; new test controls delivery rather than recreating the entire planner-radio simulation."
],
"supporting_source_sha256": {
"ERR_HQCoordinated.c": "5b67ad624c4a6b0bbb715314ab9cf14e527018fccb7d38af479184b4952b8c49",
"ERR_HQOperations.c": "b83b805c61c3960801d24ae54854ba7aa4dc914ea89e61db365b5ec99f305ae5",
"ERR_HQSquadJudgment.c": "12e9ccc9d42a858a998bd46708fbb04d05d48dcf460303a5ecc1629021051bb4"
}
}