Files
EscapistsReintroduced/docs/evidence/depot-porter-pair-2026-10-03/independent/review.json
T
jakub 6a667d8deb Capture current mission, AI, map and administration development
Include the current addon, terrain integrations, tools, regression tests and recorded development evidence.
2026-10-13 22:52:53 +02:00

30 lines
3.3 KiB
JSON

{
"complete": true,
"phase": "Frozen source and final actual-method regression independently reviewed",
"concrete_defect": "First otherwise eligible original member is pinned before any source magazine is considered; incompatible first member prevents later compatible original workers from ever being selected.",
"required_alignment": "SelectWorker must include ERR_EnemyEquipmentRules.Eligible(mode,crew.Group,actor), already required by WorkerValid. Its military/captured-group ownership checks are not implied by Quiet/CanAttribute/CanFight.",
"ownership": "Pin worker/slot/utility only after exact pair compatibility and original attribution. Keep reserve/attempt/downlink after selection; do not change transfer leaf callback quarantine or finite reservation semantics.",
"budget": "Existing caps are20services,64sites,96items,32members;3072 is per eligible camp/truck pair, not global Plan. Compatibility has bounded native weapon/muzzle scans; no measured performance claim.",
"test_contract": [
"Execute actual SelectWorker plus Plan; first original incompatible and second compatible must succeed on second, baseline compile then runtime failure.",
"Eligibility-false first candidate cannot hide eligible compatible later actor; no eligible pair leaves attempts/claims/orders unchanged.",
"Original first compatible still selected; roster>32 rejects; source absent/spent/used/empty still excluded; compatibility call count bounded.",
"Retain existing controller Stop/quarantine/late proof tests; no need duplicate entire native Compatible harness."
],
"actions": "Read-only source inspection, messages only; no compiler/native/target writes.",
"production_approved": true,
"source_sha256": "dbc699f63d826aa6c57122483927e5092840f3fa6470f17f0acba710447b00ce",
"patch_sha256": "f130aa796c7314ffd3e50991eed985621bb5787f845ef3911935e3779784c5da",
"source_conclusion": "Only SelectWorker/Plan changed: exact source item guards precede bounded original-roster scan; full existing Eligible replaces CanFight, retaining fitness plus mission/military/capture checks. Pin occurs only after native agent utility and item compatibility. Reserve/attempt/radio/finite claim/Stop/late callback code unchanged.",
"test_sha256": "30bdc7b45671826296565908b313c0cdfff41698a2fc08deb519f96dafe6b43c",
"original_lifecycle_assertions_byte_identical": true,
"test_conclusion": "Actual SelectWorker is extracted alongside actual Plan, Tick, Abort, Stop and delivery methods. Native pair compatibility explicitly doubles well/positive ammo; native ownership/AI boundaries remain doubled. Baseline log shows compiled executable aborting at mixed-roster admission assertion; green log reports pass. Existing lifecycle assertions remain byte-identical from first preexisting case through harness invocation; fixture setup adds valid original roster/agent data without relaxing prior assertions.",
"independent_execution": false,
"limitations": "Read-only source/log verification only; no native eligibility/navigation/physical-transfer or multiplayer proof.",
"test_artifact_hashes": {
"red.log": "f5cb622ab9764fe007d61ec7e1b771a6dd88d3766829f93e6ad1c24314974aaa",
"green.log": "491d5709202ea176318751587693c7929ef8f4710bbc00a1a27f3aa45ba0158b",
"review.json": "d91e2a6b374419d4d2becc235162ec09d0ce909135d85a386a41eb3f09f03907"
}
}