jakub
6a667d8deb
Include the current addon, terrain integrations, tools, regression tests and recorded development evidence.
26 lines
2.5 KiB
JSON
26 lines
2.5 KiB
JSON
{
|
|
"source": "/tmp/erri-pair-hq-0054/addons/core/Scripts/Game/ERR/10_AI/ERR_HQMountedDispatch.c",
|
|
"reviewed_sha256": "adf4ee9dfde64b159f2335b80118f64878dba7239b41d105c0a25ade85f1e11d",
|
|
"verdict": "One concrete pre-admission pair-selection defect reported to author/root; no additional demonstrated safety blocker in reviewed dispatcher.",
|
|
"finding": {
|
|
"method": "PlanMountedIntercept paired candidate selection",
|
|
"problem": "Greedy closestA excludes the only escort capable of reachingB; singleton fallback may occur despite a complete admissible pair.",
|
|
"reproducer": "Response radius800; destinations A.x=0,B.x=60; original same-convoy eligible U.x=0,V.x=-800. U is closestA; V cannot reachB(860). V\u2192A,U\u2192B is feasible. Both radios and original status otherwise valid.",
|
|
"required_change": "Bounded enumeration of eligible original escort assignments/permutations before pre-admission singleton fallback. At most3 escort slots. Add actual planner regression.",
|
|
"status": "Sent to hq_memory_review and root; reviewer makes no edits."
|
|
},
|
|
"reviewed_good": [
|
|
"queries increments before pair and single selection; per-pass<=2 includes failed pair+fallback. Rotating belief cursor advances even when both queries spent on one blocked track.",
|
|
"Two independent strongly-owned routes, two latched receipt flags; ApplyInterceptPair only after both positive real Advance results and both original status/contact/claim checks.",
|
|
"Assigned and HuntingAssigned count each member once; role eligibility excludes base assignments, pending orders and logistics. Pending/current pair respects global and hunting caps.",
|
|
"Separate monotonically allocated400001..400256 tokens spend1or2; refusal preserves spent attempt/revision, no post-claim fallback or partner replacement.",
|
|
"Release detaches both HQ job refs before native service release, clears only matching HQ logistics tokens and retains unrelated claims. ReleaseUnit of either original ends both.",
|
|
"Pending order chronology enforces same delivered belief/revision/report,30-second delivery freshness and fixed120-second observation expiry. Active job intentionally retains immutable order until expiry; no live player retargeting."
|
|
],
|
|
"service_boundary_note": "ClearIntercept still performs native waypoint removal before token reset; sent author targeted direct-vehicle reentrancy question. No demonstrated engine callback reproduction, so not asserted as a blocker.",
|
|
"tests_run": false,
|
|
"target_writes": false,
|
|
"source_edits": false,
|
|
"native": false
|
|
}
|