From dab91eab6eb8bf6d7c36f88c3b9f291112a9c378 Mon Sep 17 00:00:00 2001
From: "martin.fencl" <martin@martinfencl.eu>
Date: Thu, 6 Aug 2026 17:53:26 +0200
Subject: [PATCH] test

---
 nextcloud/check_stack_nextcloud.yml | 57 ++++++++---------------------
 1 file changed, 16 insertions(+), 41 deletions(-)

diff --git a/nextcloud/check_stack_nextcloud.yml b/nextcloud/check_stack_nextcloud.yml
index 07d06c7..e8fd969 100644
--- a/nextcloud/check_stack_nextcloud.yml
+++ b/nextcloud/check_stack_nextcloud.yml
@@ -1,21 +1,11 @@
 # nextcloud/check_stack_nextcloud.yml
 
-- name: Run Nextcloud maintenance on VM via Proxmox
-  hosts: proxmox_nextcloud
+- name: Run Nextcloud maintenance
+  hosts: nextcloud
   gather_facts: false
   become: true
-  become_user: root
-  become_method: sudo
-
 
   vars:
-    vm_ip:   "{{ lookup('env', 'VM_IP') }}"
-    vm_user: "{{ lookup('env', 'VM_USER') }}"
-    vm_pass: "{{ lookup('env', 'VM_PASS') }}"
-
-    # Flip to true if Docker needs sudo on the VM
-    use_sudo: false
-
     vm_commands:
       - "docker exec -u www-data nextcloud php -f /var/www/html/cron.php"
       - "docker exec -u www-data nextcloud php occ app:update --all"
@@ -24,45 +14,30 @@
       - "set -o pipefail; timeout 180s bash -x /data/compose/nextcloud/stack-health.sh </dev/null"
 
   tasks:
-    - name: Ensure sshpass is installed (for password-based SSH)  # English comments
-      ansible.builtin.apt:
-        name: sshpass
-        state: present
-        update_cache: yes
-
-    - name: Run Nextcloud commands on VM (via SSH, argv, no line breaks)
-      ansible.builtin.command:
-        argv:
-          - sshpass
-          - -p
-          - "{{ vm_pass }}"
-          - ssh
-          - -o
-          - StrictHostKeyChecking=no
-          - -o
-          - ConnectTimeout=15
-          - "{{ vm_user }}@{{ vm_ip }}"
-          - bash
-          - -lc
-          - "{{ ('sudo ' if use_sudo else '') + item }}"
+    - name: Run Nextcloud commands
+      ansible.builtin.shell:
+        cmd: "{{ item }}"
+        executable: /bin/bash
       loop: "{{ vm_commands }}"
       register: vm_cmds
       changed_when: false
+      failed_when: false
 
-    - name: Show outputs for each command
+    - name: Show command outputs
       ansible.builtin.debug:
         msg: |
           CMD: {{ item.item }}
-          RC:  {{ item.rc }}
+          RC: {{ item.rc }}
           STDOUT:
-          {{ (item.stdout | default('')).strip() }}
+          {{ item.stdout | default('') }}
           STDERR:
-          {{ (item.stderr | default('')).strip() }}
+          {{ item.stderr | default('') }}
       loop: "{{ vm_cmds.results }}"
 
-    - name: Fail play if any command failed
+    - name: Fail when a command failed
       ansible.builtin.assert:
-        that: "item.rc == 0"
-        fail_msg: "Command failed on VM: {{ item.item }} (rc={{ item.rc }})"
-        success_msg: "All commands succeeded."
+        that:
+          - item.rc == 0
+        fail_msg: "Command failed: {{ item.item }} (rc={{ item.rc }})"
+        quiet: true
       loop: "{{ vm_cmds.results }}"