From ba1e2f74adc2fa11a48a16fce281aa1b17ec143c Mon Sep 17 00:00:00 2001
From: "martin.fencl" <martin@martinfencl.eu>
Date: Thu, 6 Aug 2026 18:31:26 +0200
Subject: [PATCH] fix: enhance Nextcloud upgrade process with detailed output
 and failure handling

---
 nextcloud/update_nextcloud_v2.yml | 32 ++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/nextcloud/update_nextcloud_v2.yml b/nextcloud/update_nextcloud_v2.yml
index 7b92a05..3dfae8f 100644
--- a/nextcloud/update_nextcloud_v2.yml
+++ b/nextcloud/update_nextcloud_v2.yml
@@ -321,7 +321,7 @@
               {{ nc_backup.stderr | default('') | trim }}
           when: debug_level == 1
 
-        - name: Nextcloud | Pull image and upgrade
+                - name: Nextcloud | Pull image and upgrade
           ansible.builtin.command:
             argv:
               - sshpass
@@ -350,8 +350,38 @@
           environment:
             SSHPASS: "{{ vm_password }}"
           register: nc_upgrade
+          changed_when: nc_upgrade.rc == 0
+          failed_when: false
           no_log: true
 
+        - name: Nextcloud | Show upgrade output
+          ansible.builtin.debug:
+            msg: |
+              Upgrade return code: {{ nc_upgrade.rc }}
+
+              STDOUT:
+              {{ nc_upgrade.stdout | default('') | trim }}
+
+              STDERR:
+              {{ nc_upgrade.stderr | default('') | trim }}
+
+        - name: Nextcloud | Fail when upgrade command failed
+          ansible.builtin.assert:
+            that:
+              - nc_upgrade.rc == 0
+            fail_msg: |
+              Nextcloud upgrade failed.
+
+              Return code:
+              {{ nc_upgrade.rc }}
+
+              STDOUT:
+              {{ nc_upgrade.stdout | default('') | trim }}
+
+              STDERR:
+              {{ nc_upgrade.stderr | default('') | trim }}
+            quiet: true
+
         - name: Nextcloud | Show upgrade output
           ansible.builtin.debug:
             msg: |