From 54d5b2828b3bec3b068d0fb36c9891a83c6b2f79 Mon Sep 17 00:00:00 2001
From: "martin.fencl" <martin@martinfencl.eu>
Date: Sun, 9 Aug 2026 10:53:22 +0200
Subject: [PATCH] fix: clean up Minecraft Docker Compose configuration by
 removing unused variables and improving formatting

---
 docker-compose/docker-compose-minecraft.yml | 50 +++++++++++++++------
 1 file changed, 36 insertions(+), 14 deletions(-)

diff --git a/docker-compose/docker-compose-minecraft.yml b/docker-compose/docker-compose-minecraft.yml
index 3c5ee8e..23703cd 100644
--- a/docker-compose/docker-compose-minecraft.yml
+++ b/docker-compose/docker-compose-minecraft.yml
@@ -3,20 +3,20 @@ services:
     image: itzg/minecraft-server:2026.6.0-java17
     container_name: mc-futurecraft
     restart: unless-stopped
+
     ports:
       - "25565:25565"
+
     environment:
       EULA: "TRUE"
+
+      # CurseForge modpack
       TYPE: "AUTO_CURSEFORGE"
       CF_API_KEY: "${CF_API_KEY}"
-      CF_PAGE_URL: "https://www.curseforge.com/minecraft/modpacks/futurecraft-5-0"
-      CF_MODPACK_ZIP: "/modpacks/futurecraft-5.0.zip"
-      # mkdir -p /home/howard/.ansible-compose/docker-compose/modpacks && curl -L -o /home/howard/.ansible-compose/docker-compose/modpacks/futurecraft-5.0.zip "https://edge.forgecdn.net/files/6103/327/Futurecraft%205.0.zi>
-      #CF_SLUG: "futurecraft-5-0"
-      #CF_FILE_ID: "6103327"
-
-      JAVA_VERSION: "17"
+      CF_SLUG: "futurecraft-5-0"
+      CF_FILE_ID: "6103327"
 
+      # Server
       MEMORY: "${MEMORY:-10G}"
       LEVEL: "world"
       DIFFICULTY: "normal"
@@ -24,31 +24,53 @@ services:
       SIMULATION_DISTANCE: "6"
       MAX_PLAYERS: "5"
 
+      # RCON
       ENABLE_RCON: "true"
       RCON_PASSWORD: "${RCON_PASSWORD}"
+
+      # Authentication / whitelist
       ONLINE_MODE: "FALSE"
       ENABLE_WHITELIST: "TRUE"
+
     volumes:
       - mc_data:/data
-      - ./modpacks:/modpacks:ro
+
 
   backup:
     image: itzg/mc-backup:latest
     container_name: mc-futurecraft-backup
     restart: unless-stopped
+
     depends_on:
-      - mc
+      mc:
+        condition: service_healthy
+
     environment:
-      SRC_DIR: /data
-      DEST_DIR: /data/backups
+      SRC_DIR: "/data"
+      DEST_DIR: "/backups"
+
       BACKUP_INTERVAL: "12h"
-      INITIAL_DELAY: "5m"
+      INITIAL_DELAY: "0"
+
+      # Delete backups older than 14 days
       PRUNE_BACKUPS_DAYS: "14"
+
+      # Don't include generated/unnecessary directories
       EXCLUDES: "backups,cache,logs"
-      RCON_HOST: mc
+
+      # RCON connection to Minecraft
+      RCON_HOST: "mc"
       RCON_PASSWORD: "${RCON_PASSWORD}"
+
     volumes:
-      - mc_data:/data
+      # Minecraft data only read-only for backup container
+      - mc_data:/data:ro
+
+      # Backups stored OUTSIDE Minecraft data volume
+      - /backups/minecraft-futurecraft:/backups
+
 
 volumes:
   mc_data:
+    external: true
+    name: docker-compose_mc_data
\ No newline at end of file