From 3fdea9f9603d22af4dfba7fbecf1d712c221c8f6 Mon Sep 17 00:00:00 2001
From: fencl <martin@martinfencl.eu>
Date: Sun, 5 Oct 2025 08:48:47 +0200
Subject: [PATCH] Refactor miniplay.yml: remove outdated documentation and
 improve VM hostname retrieval method for clarity and efficiency.

---
 nextcloud/miniplay.yml | 40 +++++++++++++++-------------------------
 1 file changed, 15 insertions(+), 25 deletions(-)

diff --git a/nextcloud/miniplay.yml b/nextcloud/miniplay.yml
index a7ea77e..e36c6b3 100644
--- a/nextcloud/miniplay.yml
+++ b/nextcloud/miniplay.yml
@@ -1,21 +1,3 @@
-# """
-# Run the command and check the response.
-#
-# :parameter command: The command to be executed.
-# :parameter add_command: Whether to include the command in the database values.
-# :parameter add_response: Whether to include the response in the database values.
-# :parameter measurement: The measurement index for the command.
-# :parameter measure_retries: The number of retries for measurement in case of failure.
-# :parameter check_port: Whether to check the port before sending the command.
-# :parameter response_equals: The expected response string to compare against.
-# :parameter response_length: The expected length or format of the response.
-# :parameter send_skipped: Whether to mark the test as skipped without execution.
-# :parameter no_response: Whether to expect no response from the command.
-# :parameter expect_patch_id_decimal: The expected patch ID in decimal format for validation.
-# :parameter response_equals_match: The expected response string to match against.
-# :return: RunResultType
-# """
-
 - name: Get VM hostname via Proxmox jump
   hosts: proxmox
   gather_facts: false
@@ -29,21 +11,29 @@
     vm_pass: "Papadopolus0"
 
   tasks:
-    - name: Ensure sshpass is installed (for password-based SSH)
+    - name: Ensure sshpass is installed (for password-based SSH)  # English comments as requested
       ansible.builtin.apt:
         name: sshpass
         state: present
         update_cache: yes
 
-    - name: Get hostname from VM
-      ansible.builtin.command: >
-        bash -lc "sshpass -p '{{ vm_pass }}'
-        ssh -o StrictHostKeyChecking=no
-           -o ConnectTimeout=10
-           {{ vm_user }}@{{ vm_ip }} hostname"
+    - name: Get hostname from VM using argv (no shell, no line breaks)
+      ansible.builtin.command:
+        argv:
+          - sshpass
+          - -p
+          - "{{ vm_pass }}"
+          - ssh
+          - -o
+          - StrictHostKeyChecking=no
+          - -o
+          - ConnectTimeout=10
+          - "{{ vm_user }}@{{ vm_ip }}"
+          - hostname
       register: vm_hostname
       changed_when: false
       failed_when: vm_hostname.rc != 0
+      no_log: false  # set to true once you move creds into Vault
 
     - name: Print VM hostname
       ansible.builtin.debug: