From 0fd5ef9e419186dc952651b87c17f369fc256def Mon Sep 17 00:00:00 2001
From: "martin.fencl" <martin@martinfencl.eu>
Date: Wed, 10 Dec 2025 12:11:05 +0100
Subject: [PATCH] edit

---
 update_immich.yml | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/update_immich.yml b/update_immich.yml
index 3b53d29..7aadc5b 100644
--- a/update_immich.yml
+++ b/update_immich.yml
@@ -39,7 +39,7 @@
 
     # Docker command prefix (consistent behavior and quiet hints)
     docker_prefix: "unalias docker 2>/dev/null || true; DOCKER_CLI_HINTS=0; command docker"
-
+    
     # Commands to run on the target VM (quiet outputs)
     # 1) Check directory exists (we do NOT create anything, to stay safe)
     # 2) Safely download latest docker-compose.yml from GitHub (with backup)
@@ -47,27 +47,33 @@
     # 4) Start / update stack
     immich_commands:
       - >-
-          if [ ! -d '{{ immich_compose_dir }}' ]; then
-            echo 'ERROR: Directory {{ immich_compose_dir }} does not exist on VM; not touching anything.' >&2;
+          [ -d "{{ immich_compose_dir }}" ] || {
+            echo "ERROR: Directory {{ immich_compose_dir }} does not exist on VM; not touching anything." >&2;
             exit 1;
-          fi
+          }
       - >-
-          cd '{{ immich_compose_dir }}' &&
-          wget -qO docker-compose.yml.new "{{ immich_compose_url }}" || true;
+          cd "{{ immich_compose_dir }}" &&
+          wget -qO docker-compose.yml.new "{{ immich_compose_url }}" || {
+            echo "ERROR: Failed to download docker-compose.yml from GitHub; keeping existing one." >&2;
+            rm -f docker-compose.yml.new 2>/dev/null || true;
+            exit 1;
+          };
           if [ -s docker-compose.yml.new ]; then
-            echo 'Downloaded new docker-compose.yml from GitHub (Immich latest).';
+            echo "Downloaded new docker-compose.yml from GitHub (Immich latest).";
             if [ -f docker-compose.yml ]; then
               cp docker-compose.yml "docker-compose.yml.bak-$(date +%F_%H-%M-%S)";
-              echo 'Existing docker-compose.yml backed up.';
+              echo "Existing docker-compose.yml backed up.";
             fi;
             mv docker-compose.yml.new docker-compose.yml;
           else
-            echo 'WARNING: Failed to download a valid docker-compose.yml, keeping existing one.' >&2;
+            echo "WARNING: Downloaded docker-compose.yml.new is empty; keeping existing one." >&2;
             rm -f docker-compose.yml.new 2>/dev/null || true;
+            exit 1;
           fi
       - "{{ docker_prefix }} compose -p {{ immich_project }} -f {{ immich_compose_file }} pull >/dev/null"
       - "{{ docker_prefix }} compose -p {{ immich_project }} -f {{ immich_compose_file }} up -d --remove-orphans >/dev/null"
 
+
   tasks:
     - name: Ensure sshpass is installed (for password-based SSH)  # English comments
       ansible.builtin.apt: